Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] Check email validity before opening an SMTP connection #33471

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@fabpot
Copy link
Member

commented Sep 5, 2019

Q A
Branch? 4.4
Bug fix? yes-ish
New feature? yes
BC breaks? no-ish
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

When using an SMTP server to send emails, the connection to the SMTP server happens before being sure that the email to sent is valid. That does not happen with HTTP transports.

This pull request implements a new method to be sure that we don't connect to the SMTP server if the email is not valid.

@fabpot fabpot force-pushed the fabpot:mailer-check-email-before-starting-smtp branch from 264f3f6 to 7152c86 Sep 5, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019

@fabpot fabpot force-pushed the fabpot:mailer-check-email-before-starting-smtp branch from 7152c86 to 3a5fe8c Sep 6, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

There's a related failure :)

@fabpot fabpot force-pushed the fabpot:mailer-check-email-before-starting-smtp branch from 3a5fe8c to dc376f5 Sep 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@fabpot fabpot force-pushed the fabpot:mailer-check-email-before-starting-smtp branch from b026b86 to dc376f5 Sep 6, 2019

fabpot added a commit that referenced this pull request Sep 6, 2019
feature #33471 [Mailer] Check email validity before opening an SMTP c…
…onnection (fabpot)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Check email validity before opening an SMTP connection

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes-ish
| New feature?  | yes
| BC breaks?    | no-ish
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

When using an SMTP server to send emails, the connection to the SMTP server happens before being sure that the email to sent is valid. That does not happen with HTTP transports.

This pull request implements a new method to be sure that we don't connect to the SMTP server if the email is not valid.

Commits
-------

dc376f5 [Mailer] Check email validity before opening an SMTP connection

@fabpot fabpot merged commit dc376f5 into symfony:4.4 Sep 6, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
fabbot.io Your code looks good.
Details

@fabpot fabpot deleted the fabpot:mailer-check-email-before-starting-smtp branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.