Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Fix 4.3 tests forward compat #33479

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@yceruto
Copy link
Member

commented Sep 5, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33478
License MIT
Doc PR -
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

What about the BC break part @derrabus mentions in the linked issue? I didn't try to understand it, what about you? :)

@yceruto

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

What about the BC break part @derrabus mentions in the linked issue? I didn't try to understand it, what about you? :)

It's not a BC break to me, but a side effect of the previous behavior related to PHPUnit and the exception handler. See #33478 (comment)

@yceruto yceruto force-pushed the yceruto:fix_43_tests branch from b36ed53 to 2ee0919 Sep 5, 2019

@yceruto yceruto force-pushed the yceruto:fix_43_tests branch 2 times, most recently from 2a7413b to f092331 Sep 5, 2019

@@ -1,5 +1,5 @@
imports:
- { resource: ./../config/framework.yml }
- { resource: ./../config/default.yml }

This comment has been minimized.

Copy link
@Tobion

Tobion Sep 5, 2019

Member

should that be reverted in 4.4 again?

This comment has been minimized.

Copy link
@yceruto

yceruto Sep 5, 2019

Author Member

Yap!

@Tobion
Tobion approved these changes Sep 5, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Thank you @yceruto.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
minor #33479 [SecurityBundle] Fix 4.3 tests forward compat (yceruto)
This PR was merged into the 4.3 branch.

Discussion
----------

[SecurityBundle] Fix 4.3 tests forward compat

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33478
| License       | MIT
| Doc PR        | -

Commits
-------

f092331 Fix 4.3 tests forward compat

@nicolas-grekas nicolas-grekas merged commit f092331 into symfony:4.3 Sep 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
minor #33495 [SecurityBundle] Removed workaround introduced in 4.3 (y…
…ceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle] Removed workaround introduced in 4.3

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Cleanup of #33479

Commits
-------

d14aaf6 Removed workaround introduced in 4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.