Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] fix empty amqp body returned as false #33481

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@Tobion
Copy link
Member

commented Sep 5, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Having false in the body breaks typehints in the serializer and is not consistent with other transports like doctrine. See pdezwart/php-amqp#351

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Thank you @Tobion.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
bug #33481 [Messenger] fix empty amqp body returned as false (Tobion)
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] fix empty amqp body returned as false

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Having `false` in the body breaks typehints in the serializer and is not consistent with other transports like doctrine. See pdezwart/php-amqp#351

Commits
-------

ee5cbe3 [Messenger] fix empty amqp body returned as false

@nicolas-grekas nicolas-grekas merged commit ee5cbe3 into symfony:4.3 Sep 6, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

@Tobion Tobion deleted the Tobion:amqp-false-body branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.