Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridge/Twig] use tty group on testLintDefaultPaths #33490

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 6, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33446 (comment)
License MIT
Doc PR -

Note that I still think we should deprecate reading from STDIN when not explicitly asked for, as explained in #33446 (comment)

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
minor #33490 [Bridge/Twig] use tty group on testLintDefaultPaths (nic…
…olas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[Bridge/Twig] use tty group on testLintDefaultPaths

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33446 (comment)
| License       | MIT
| Doc PR        | -

Note that I still think we should deprecate reading from STDIN when not explicitly asked for, as explained in #33446 (comment)

Commits
-------

3c59bb5 [Bridge/Twig] use tty group on testLintDefaultPaths

@nicolas-grekas nicolas-grekas merged commit 3c59bb5 into symfony:4.4 Sep 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:tty branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.