Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MonologBridge] Bump min version for monolog ^1.25 and drop dead code #33492

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@lyrixx
Copy link
Member

commented Sep 6, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@lyrixx lyrixx force-pushed the lyrixx:monolog-simplify branch from fa89351 to 31f87e3 Sep 6, 2019

@lyrixx lyrixx force-pushed the lyrixx:monolog-simplify branch from 31f87e3 to c4cef83 Sep 6, 2019

@lyrixx lyrixx changed the title [MonologBridge] Bump min version for monolog ^1.25 and drop dead code [DO NOT MERGE][MonologBridge] Bump min version for monolog ^1.25 and drop dead code Sep 6, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

I block this PR: It will need Seldaek/monolog#1374 and a new monolog release

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019

composer.json Outdated Show resolved Hide resolved

@lyrixx lyrixx force-pushed the lyrixx:monolog-simplify branch from 6dde6de to 1e19c65 Sep 6, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

Travis failures are not related

@lyrixx lyrixx changed the title [DO NOT MERGE][MonologBridge] Bump min version for monolog ^1.25 and drop dead code [MonologBridge] Bump min version for monolog ^1.25 and drop dead code Sep 6, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
minor #33492 [MonologBridge] Bump min version for monolog ^1.25 and d…
…rop dead code (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[MonologBridge] Bump min version for monolog ^1.25 and drop dead code

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

1e19c65 [MonologBridge] Bump min version for monolog ^1.25 and drop dead code

@nicolas-grekas nicolas-grekas merged commit 1e19c65 into symfony:4.4 Sep 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details
@derrabus

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Does that change also affect the minimal Monolog 2 version on master?

@lyrixx lyrixx deleted the lyrixx:monolog-simplify branch Sep 6, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@derrabus I think it should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.