Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfiler] Deprecated intercept_redirects in 4.4 #33507

Open
wants to merge 4 commits into
base: 4.4
from

Conversation

@dorumd
Copy link
Contributor

commented Sep 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #33467
License MIT
Doc PR -

Deprecated web_profiler.intercept_redirects config option in symfony 4.4.

@dorumd dorumd force-pushed the dorumd:i33467 branch from 7538371 to d38e32f Sep 8, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 8, 2019

@fabpot
Copy link
Member

left a comment

Some minor comments

@dorumd

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@fabpot @ro0NL Indeed, good point about deprecating it using Configuration tooling. Please check my latest changes.

@dorumd

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@stof I have split the tests. Can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.