Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Add types to constructors and private/final/internal methods #33508

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@derrabus
Copy link
Contributor

commented Sep 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179, #33228
License MIT
Doc PR N/A

I'm currently preparing a large PR collecting changes like these. However, the changeset for the Cache component was large enough to justify a dedicated PR, imho.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Thank you @derrabus.

nicolas-grekas added a commit that referenced this pull request Sep 9, 2019
minor #33508 [Cache] Add types to constructors and private/final/inte…
…rnal methods (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] Add types to constructors and private/final/internal methods

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179, #33228
| License       | MIT
| Doc PR        | N/A

I'm currently preparing a large PR collecting changes like these. However, the changeset for the Cache component was large enough to justify a dedicated PR, imho.

Commits
-------

919afd2 [Cache] Add types to constructors and private/final/internal methods.

@nicolas-grekas nicolas-grekas merged commit 919afd2 into symfony:4.4 Sep 9, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@derrabus derrabus deleted the derrabus:improvement/cache-types branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.