Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] properly catch legacy tag syntax usages #33517

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@xabbuh
Copy link
Member

commented Sep 9, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25534
License MIT
Doc PR

@xabbuh xabbuh force-pushed the xabbuh:issue-25534 branch from 11eb0e7 to d5894a4 Sep 11, 2019

@fabpot
fabpot approved these changes Sep 11, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Sep 11, 2019
bug #33517 [Yaml] properly catch legacy tag syntax usages (xabbuh)
This PR was merged into the 4.3 branch.

Discussion
----------

[Yaml] properly catch legacy tag syntax usages

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25534
| License       | MIT
| Doc PR        |

Commits
-------

d5894a4 properly catch legacy tag syntax usages

@fabpot fabpot merged commit d5894a4 into symfony:4.3 Sep 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

@xabbuh xabbuh deleted the xabbuh:issue-25534 branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.