Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to constructors and private/final/internal methods (Batch I) #33519

Open
wants to merge 13 commits into
base: 4.4
from

Conversation

@derrabus
Copy link
Contributor

commented Sep 9, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179, #33228
License MIT
Doc PR N/A

As promised, now a larger batch with the following components:

  • Asset
  • BrowserKit
  • Config
  • Console
  • CssSelector
  • Debug
  • DomCrawler
  • DotEnv
  • ErrorHandler
  • ErrorRenderer
  • ExpressionLanguage
  • Filesystem
  • Finder

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 9, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Do we really want to add types to Tests? I'm anticipating hours on merge conflicts here. On non-test classes, it's worth it, but on tests, I'd prefer doing anything else of my future contrib time...

@stof

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

I agree with @nicolas-grekas here.

@derrabus

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

Do we really want to add types to Tests?

I find them helpful for understanding the tests.

I'm anticipating hours on merge conflicts here. On non-test classes, it's worth it, but on tests, I'd prefer doing anything else of my future contrib time...

I understand. Suggestion: I‘m going to remove changes I‘ve made to test case classes that also exist on the 3.4 branch. We can hold them back until 3.4 is EOL.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

I‘m going to remove changes I‘ve made to test case classes that also exist on the 3.4 branch. We can hold them back until 3.4 is EOL.

that'd work for me (but if it's too tedious, you can surrender :)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

Status: needs work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.