Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fix calling the buffer-enabling callback #33524

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 10, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
@stof

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Please add some tests covering this to prevent regressions.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-push-buffer branch from 01ea03e to 0e28518 Sep 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

@stoff That's not possible, we don't have testing infrastructure for pushed responses.

@stof
stof approved these changes Sep 10, 2019
@fabpot
fabpot approved these changes Sep 10, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Sep 10, 2019
bug #33524 [HttpClient] fix calling the buffer-enabling callback (nic…
…olas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix calling the buffer-enabling callback

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

0e28518 [HttpClient] fix calling the buffer-enabling callback

@fabpot fabpot merged commit 0e28518 into symfony:4.4 Sep 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-push-buffer branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.