Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] fix Preloader #33525

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 10, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://github.com/symfony/symfony/pull/32032/files#r322150801
License MIT
Doc PR -
@stof
stof approved these changes Sep 10, 2019
@fabpot
fabpot approved these changes Sep 10, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Sep 10, 2019
bug #33525 [DI] fix Preloader (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[DI] fix Preloader

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/32032/files#r322150801
| License       | MIT
| Doc PR        | -

Commits
-------

4cc8641 [DI] fix Preloader

@fabpot fabpot merged commit 4cc8641 into symfony:4.4 Sep 10, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-dirname branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.