Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] use dirname() when possible #33529

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

On second look, I think this works :)

@stof
stof approved these changes Sep 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-dirname branch 2 times, most recently from 82c740e to 0361509 Sep 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-dirname branch from 0361509 to 2eae300 Sep 10, 2019

@@ -306,7 +312,7 @@ public function dump(array $options = [])
use Symfony\Component\DependencyInjection\Dumper\Preloader;
require dirname(__DIR__, 3).'/vendor/autoload.php';
require $autoloadFile;

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Sep 10, 2019

Author Member

now with proper detection of autoload.php location

This comment has been minimized.

Copy link
@stof

stof Sep 10, 2019

Member

Do we have any test covering the dumping of this file ?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Sep 10, 2019

Author Member

yes; not precisely this line but the $classes[] = ... one below

nicolas-grekas added a commit that referenced this pull request Sep 10, 2019
minor #33529 [DI] use dirname() when possible (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[DI] use dirname() when possible

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

On second look, I think this works :)

Commits
-------

2eae300 [DI] use dirname() when possible

@nicolas-grekas nicolas-grekas merged commit 2eae300 into symfony:4.4 Sep 10, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-dirname branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.