Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub PR template #33537

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 10, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:pr-tpl branch from 7ef6e2f to 288907a Sep 10, 2019

@lyrixx
lyrixx approved these changes Sep 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:pr-tpl branch 2 times, most recently from 835328c to 2d00167 Sep 10, 2019

@stof
stof approved these changes Sep 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:pr-tpl branch 2 times, most recently from e716751 to 975f282 Sep 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:pr-tpl branch from 975f282 to 0d03481 Sep 10, 2019

@Taluu
Taluu approved these changes Sep 10, 2019
Copy link
Contributor

left a comment

only nit-picking so 👍

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
nicolas-grekas added a commit that referenced this pull request Sep 10, 2019
minor #33537 Update GitHub PR template (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

Update GitHub PR template

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

0d03481 Update GitHub PR template

@nicolas-grekas nicolas-grekas merged commit 0d03481 into symfony:3.4 Sep 10, 2019

2 of 3 checks passed

fabbot.io Doing some proofreading and checking your coding style.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:pr-tpl branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.