Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] cascade preloading only to public parameters/properties #33541

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This removes ContainerBuilder, RouteCollectionBuilder, etc. coming from App\Kernel

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 10, 2019

nicolas-grekas added a commit that referenced this pull request Sep 10, 2019
minor #33541 [DI] cascade preloading only to public parameters/proper…
…ties (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] cascade preloading only to public parameters/properties

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This removes `ContaierBuilder`, `RouteCollectionBuilder`, etc. coming from `App\Kernel`

Commits
-------

0e3ea8f [DI] cascade preloading only to public parameters/properties

@nicolas-grekas nicolas-grekas merged commit 0e3ea8f into symfony:4.4 Sep 10, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-preload-pub branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.