Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Accept existing interfaces as valid named args #33546

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@fancyweb
Copy link
Contributor

commented Sep 11, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets #33531
License MIT
Doc PR -

@fancyweb fancyweb force-pushed the fancyweb:di-interfaces-named-args branch from 38c4a3a to 6612e9a Sep 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Sep 11, 2019
bug #33546 [DependencyInjection] Accept existing interfaces as valid …
…named args (fancyweb)

This PR was merged into the 4.3 branch.

Discussion
----------

[DependencyInjection] Accept existing interfaces as valid named args

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #33531
| License       | MIT
| Doc PR        | -

Commits
-------

6612e9a [DependencyInjection] Accept existing interfaces as valid named args

@nicolas-grekas nicolas-grekas merged commit 6612e9a into symfony:4.3 Sep 11, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

@fancyweb fancyweb deleted the fancyweb:di-interfaces-named-args branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.