Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Use a better exception message when many workflows are found #33549

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@lyrixx
Copy link
Member

commented Sep 11, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets (asked by @OskarStark on slack)
License MIT
Doc PR
@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Thanks Greg 🙏

@lyrixx lyrixx force-pushed the lyrixx:w-exception branch from 704f860 to ab23a34 Sep 11, 2019

@lyrixx lyrixx force-pushed the lyrixx:w-exception branch 2 times, most recently from 7f19913 to f5de739 Sep 12, 2019

src/Symfony/Component/Workflow/Registry.php Outdated Show resolved Hide resolved

@lyrixx lyrixx force-pushed the lyrixx:w-exception branch from f5de739 to 1862cb3 Sep 12, 2019

@fabpot
fabpot approved these changes Sep 12, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Sep 12, 2019
minor #33549 [Workflow] Use a better exception message when many work…
…flows are found (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[Workflow] Use a better exception message when many workflows are found

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | (asked by @OskarStark on slack)
| License       | MIT
| Doc PR        |

Commits
-------

1862cb3 [Workflow] Use a better exception message when many workflow are found

@fabpot fabpot merged commit 1862cb3 into symfony:4.4 Sep 12, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

@lyrixx lyrixx deleted the lyrixx:w-exception branch Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.