Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyInfo] ensure compatibility with type resolver 0.5 #33626

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@xabbuh
Copy link
Member

xabbuh commented Sep 18, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

same as #33588 but for the 3.4 branch

if ($nestedVarType instanceof Nullable) {
$varTypes[] = (string) $nestedVarType->getActualType();
$nullable = true;

This comment has been minimized.

Copy link
@OskarStark

OskarStark Sep 18, 2019

Contributor

Is it expected that this could never be false again the loop? Just asking, I am currently on a phone 😊

This comment has been minimized.

Copy link
@xabbuh

xabbuh Sep 18, 2019

Author Member

At least that's the current behaviour. The failing example docblock here was ?string|int which was expected to reveal string and int as types both being nullable.

This comment has been minimized.

Copy link
@stof

stof Sep 18, 2019

Member

the thing is, nullable applies to the whole typehint. Either null is allowed or it is not. But it cannot be both of them.

This comment has been minimized.

Copy link
@OskarStark

OskarStark Sep 18, 2019

Contributor

Thanks @stof, that’s what I thought but wanted to be sure 👍🏻

@stof
stof approved these changes Sep 18, 2019
@fabpot
fabpot approved these changes Sep 18, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Sep 18, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Sep 18, 2019
… (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[PropertyInfo] ensure compatibility with type resolver 0.5

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

same as #33588 but for the `3.4` branch

Commits
-------

2d708b3 ensure compatibility with type resolver 0.5
@fabpot fabpot merged commit 2d708b3 into symfony:3.4 Sep 18, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
@xabbuh xabbuh deleted the xabbuh:type-resolver-compat branch Sep 18, 2019
This was referenced Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.