Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PropertyInfo] ensure compatibility with type resolver 0.5 #33626
+8
−1
Conversation
| if ($nestedVarType instanceof Nullable) { | ||
| $varTypes[] = (string) $nestedVarType->getActualType(); | ||
| $nullable = true; |
This comment has been minimized.
This comment has been minimized.
OskarStark
Sep 18, 2019
Contributor
Is it expected that this could never be false again the loop? Just asking, I am currently on a phone
This comment has been minimized.
This comment has been minimized.
xabbuh
Sep 18, 2019
Author
Member
At least that's the current behaviour. The failing example docblock here was ?string|int which was expected to reveal string and int as types both being nullable.
This comment has been minimized.
This comment has been minimized.
stof
Sep 18, 2019
Member
the thing is, nullable applies to the whole typehint. Either null is allowed or it is not. But it cannot be both of them.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 18, 2019
… (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [PropertyInfo] ensure compatibility with type resolver 0.5 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | same as #33588 but for the `3.4` branch Commits ------- 2d708b3 ensure compatibility with type resolver 0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
xabbuh commentedSep 18, 2019
same as #33588 but for the
3.4branch