Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Twig 3 #33649

Merged
merged 1 commit into from Sep 23, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Sep 20, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Needs twigphp/Twig#3156
And twigphp/Twig#3158

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 20, 2019
@nicolas-grekas nicolas-grekas requested a review from xabbuh as a code owner Sep 20, 2019
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:twig3 branch Sep 20, 2019
@nicolas-grekas nicolas-grekas restored the nicolas-grekas:twig3 branch Sep 20, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:twig3 branch from e03b67c to 9d345bf Sep 20, 2019
@xabbuh
xabbuh approved these changes Sep 20, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:twig3 branch from 1b4c593 to 09f4eb5 Sep 23, 2019
@fabpot
fabpot approved these changes Sep 23, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Sep 23, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

Allow Twig 3

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Needs twigphp/Twig#3156
And twigphp/Twig#3158

Commits
-------

09f4eb5 Allow Twig 3
@fabpot fabpot merged commit 09f4eb5 into symfony:4.4 Sep 23, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.