Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] skip igbinary on PHP 7.4.0 #33652

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 20, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Our CI currently fails because of that. I'm blacklisting 7.4.0 exactly so that we don't have to maintain these lines, betting on the issue being resolved before 7.4.1 is released.

See igbinary/igbinary#237

@xabbuh
xabbuh approved these changes Sep 20, 2019
nicolas-grekas added a commit that referenced this pull request Sep 20, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Cache] skip igbinary on PHP 7.4.0

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Our CI currently fails because of that. I'm blacklisting 7.4.0 exactly so that we don't have to maintain these lines, betting on the issue being resolved before 7.4.1 is released.

See igbinary/igbinary#237

Commits
-------

2c0c131 [Cache] skip igbinary on PHP 7.4.0
@nicolas-grekas nicolas-grekas merged commit 2c0c131 into symfony:4.3 Sep 20, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:php74-igb branch Sep 20, 2019
@fabpot fabpot mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.