Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crawler] document $default as string|null #33742

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 27, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This has been introduced in 4.3

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Sep 27, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:crawler-string branch from e4fabab to 15b8913 Sep 27, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:crawler-string branch from 15b8913 to 0e6b5a5 Sep 28, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:crawler-string branch 2 times, most recently from 2eef61d to f3b00ad Sep 28, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:crawler-string branch from f3b00ad to e96add4 Sep 28, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Oct 7, 2019

@symfony/mergers OK for you?

@xabbuh
xabbuh approved these changes Oct 7, 2019
@fabpot
fabpot approved these changes Oct 7, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Oct 7, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Oct 7, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Crawler] document $default as string|null

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This has been introduced in 4.3

Commits
-------

e96add4 [Crawler] document $default as string|null
@fabpot fabpot merged commit e96add4 into symfony:4.3 Oct 7, 2019
2 of 3 checks passed
2 of 3 checks passed
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fabpot fabpot mentioned this pull request Oct 7, 2019
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:crawler-string branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.