Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to constructors and private/final/internal methods (Batch III) #33770

Merged

Conversation

@derrabus
Copy link
Contributor

commented Sep 30, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets #32179, #33228
License MIT
Doc PR N/A

Followup to #33709, this time with:

  • Validator
  • VarDumper
  • Workflow
  • Yaml
  • all bridges
  • all bundles

That should be the final batch. 馃槂

@derrabus derrabus requested review from lyrixx and xabbuh as code owners Sep 30, 2019
@derrabus derrabus force-pushed the derrabus:improvement/non-breaking-types-3 branch from cf8c178 to e4cfa7e Sep 30, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 30, 2019
@@ -59,9 +61,7 @@ public function testLoadUserByUsernameWithUserLoaderRepositoryAndWithoutProperty
{
$user = new User(1, 1, 'user1');
$repository = $this->getMockBuilder('Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface')

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Oct 2, 2019

Member

changes on this file should be reverted (and/or be submitted on 3.4)

This comment has been minimized.

Copy link
@derrabus

derrabus Oct 2, 2019

Author Contributor

and/or be submitted on 3.4

My failed attempt to do so is documented as #33771. 馃檲

The changes are necessary because the mocks are currently incomplete and because of that they wouldn't pass a return type declaration I've added.

Copy link
Member

left a comment

(with one comment)

@nicolas-grekas nicolas-grekas force-pushed the derrabus:improvement/non-breaking-types-3 branch from e4cfa7e to 6493902 Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 6493902 into symfony:4.4 Oct 7, 2019
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Doing some proofreading and checking your coding style.
Details
@derrabus derrabus deleted the derrabus:improvement/non-breaking-types-3 branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.