Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy phpunit.xsd to a predictable path #33776

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@julienfalque
Copy link
Contributor

julienfalque commented Sep 30, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? yes-ish
Deprecations? no
Tickets symfony/recipes#652 (comment)
License MIT
Doc PR -

In symfony/recipes#652 I would like to make Flex create the phpunit.xml.dist file with a local URI for the phpunit.xsd. This is doable when using phpunit/phpunit standalone because the path to the XSD file is known. This PR aims to allow doing this when using the PHPUnit Bridge, which installs PHPUnit in a path that might change.

Is is simple @copy() call ok? Should I add some error handling?

Copy link
Member

nicolas-grekas left a comment

LGTM thanks :)

@fabpot
fabpot approved these changes Sep 30, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Sep 30, 2019

Thank you @julienfalque.

fabpot added a commit that referenced this pull request Sep 30, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Copy phpunit.xsd to a predictable path

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes-ish
| Deprecations? | no
| Tickets       | symfony/recipes#652 (comment)
| License       | MIT
| Doc PR        | -

In symfony/recipes#652 I would like to make Flex create the `phpunit.xml.dist` file with a local URI for the `phpunit.xsd`. This is doable when using `phpunit/phpunit` standalone because the path to the XSD file is known. This PR aims to allow doing this when using the PHPUnit Bridge, which installs PHPUnit in a path that might change.

Is is simple `@copy()` call ok? Should I add some error handling?

Commits
-------

233dcb4 Copy phpunit.xsd to a predictable path
@fabpot fabpot merged commit 233dcb4 into symfony:3.4 Sep 30, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
@julienfalque julienfalque deleted the julienfalque:local-phpunit-xsd branch Oct 1, 2019
This was referenced Oct 7, 2019
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 26, 2019
@fabpot fabpot mentioned this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.