Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] dont mandate a class on inline services with a factory #33782

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Oct 1, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This check is too strict, useless and boring for inline services :)

@stof

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

should this be covered by a test to prevent regressions ? I think the answer should be yes.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-inline-no-factory branch from 124ea65 to a2665d1 Oct 2, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

Now with tests.

nicolas-grekas added a commit that referenced this pull request Oct 2, 2019
…ory (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] dont mandate a class on inline services with a factory

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This check is too strict, useless and boring for inline services :)

Commits
-------

a2665d1 [DI] dont mandate a class on inline services with a factory
@nicolas-grekas nicolas-grekas merged commit a2665d1 into symfony:4.4 Oct 2, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-inline-no-factory branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.