Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[DI] dont mandate a class on inline services with a factory #33782
nicolas-grekas added a commit that referenced this pull request
Oct 2, 2019
…ory (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] dont mandate a class on inline services with a factory | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This check is too strict, useless and boring for inline services :) Commits ------- a2665d1 [DI] dont mandate a class on inline services with a factory
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.