Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand #33805

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@jschaedl
Copy link
Contributor

jschaedl commented Oct 2, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33747
License MIT
Doc PR -

This is a follow-up PR caused by #33775 (comment)

@xabbuh
xabbuh approved these changes Oct 2, 2019
@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Oct 2, 2019

Thank you Jan.

xabbuh added a commit that referenced this pull request Oct 2, 2019
…DebugCommand (jschaedl)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #33747<!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | -

This is a follow-up PR caused by #33775 (comment)

Commits
-------

9b5ced2 [FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand
@xabbuh xabbuh merged commit 9b5ced2 into symfony:3.4 Oct 2, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Oct 2, 2019
…ling Command::execute() (jschaedl)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Console] Throw a TypeError for non-int return value calling Command::execute()

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #33747 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

### Todo

- [x] needs to be rebased after 4.4 was merged into master (see: #33805)

Commits
-------

b3a3b0c [Console] Throw a TypeError for non-int return values on calling Command::execute()
This was referenced Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.