Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] Throw exception for tagged invalid inline elements #33818

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@gharlan
Copy link
Contributor

gharlan commented Oct 2, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

At the moment the result for !foo 'don't do somthin' like that' is a TaggedValue with value "don".

@gharlan gharlan requested a review from xabbuh as a code owner Oct 2, 2019
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 2, 2019
Copy link
Member

xabbuh left a comment

with a minor comment, should be merged into 3.4 if I don't miss anything

src/Symfony/Component/Yaml/Tests/InlineTest.php Outdated Show resolved Hide resolved
@xabbuh xabbuh modified the milestones: 4.3, 3.4 Oct 15, 2019
@gharlan

This comment has been minimized.

Copy link
Contributor Author

gharlan commented Oct 15, 2019

should be merged into 3.4 if I don't miss anything

Tagged scalars were introduced in 4.0.

@gharlan gharlan force-pushed the gharlan:yaml-tag-fix branch from 0ab8404 to a1b9968 Oct 15, 2019
@xabbuh xabbuh modified the milestones: 3.4, 4.3 Oct 15, 2019
@gharlan

This comment has been minimized.

Copy link
Contributor Author

gharlan commented Oct 15, 2019

Oh, but it seems that tagged inline arrays are also affected (in 3.4).

!foo [bar] baz

This does not throw an exception.

So I will change target to 3.4 and fix it there.

Status: Needs Work

@xabbuh xabbuh dismissed their stale review Oct 15, 2019

wait for 3.4 fixes

@gharlan gharlan force-pushed the gharlan:yaml-tag-fix branch from a1b9968 to c1d0e50 Oct 15, 2019
@gharlan gharlan changed the title [Yaml] Throw exception for invalid tagged scalar [Yaml] Throw exception for tagged invalid inline elements Oct 15, 2019
@gharlan gharlan changed the base branch from 4.3 to 3.4 Oct 15, 2019
@gharlan gharlan force-pushed the gharlan:yaml-tag-fix branch from c1d0e50 to bed479c Oct 15, 2019
@gharlan gharlan requested a review from xabbuh Oct 15, 2019
@xabbuh
xabbuh approved these changes Oct 16, 2019
@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Oct 18, 2019

Thank you @gharlan.

xabbuh added a commit that referenced this pull request Oct 18, 2019
…(gharlan)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] Throw exception for tagged invalid inline elements

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

At the moment the result for `!foo 'don't do somthin' like that'` is a `TaggedValue` with value "don".

Commits
-------

bed479c [Yaml] Throw exception for tagged invalid inline elements
@xabbuh xabbuh merged commit bed479c into symfony:3.4 Oct 18, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@gharlan gharlan deleted the gharlan:yaml-tag-fix branch Oct 18, 2019
This was referenced Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.