Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] encourage installing intl when String is available #33825

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Oct 3, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:s-intl branch from eb6b081 to 147152a Oct 3, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:s-intl branch 2 times, most recently from 8b4ce15 to e5da792 Oct 3, 2019
@yceruto
yceruto approved these changes Oct 3, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:s-intl branch from e5da792 to 215595b Oct 4, 2019
nicolas-grekas added a commit that referenced this pull request Oct 4, 2019
…is available (nicolas-grekas)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[FrameworkBundle] encourage installing intl when String is available

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

215595b [FrameworkBundle] encourage installing intl when String is available
@nicolas-grekas nicolas-grekas merged commit 215595b into symfony:master Oct 4, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:s-intl branch Oct 4, 2019
@jakzal

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Unfortunately, this makes the intl extension required if the String component is present :(

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

We should skip the notice if \defined('PHPUNIT_COMPOSER_INSTALL'), that should be enough.

@jakzal

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Won't this only fix the tests? The intl extension will still be required if the String component is present.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

Not with polyfills - or did you spot something that is not polyfilled?

@jakzal

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Nope, I understand now :)

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #33868).

Discussion
----------

Skip the intl notice if run with phpunit

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Re #33825
| License       | MIT
| Doc PR        | -

Commits
-------

25461b3 Skip the intl notice if run with phpunit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.