Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fix "no_proxy" option ignored in NativeHttpClient #33853

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@Harry-Dunne
Copy link
Contributor

commented Oct 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33832
License MIT
Doc PR

Allow overriding of no_proxy environment variable by passing no_proxy option in NativeHttpClient::request() method.

…::request() method
@nicolas-grekas nicolas-grekas changed the title [HttpClient] Fixed #33832 NO_PROXY option ignored in NativeHttpClient… [HttpClient] Fixed #33832 NO_PROXY option ignored in NativeHttpClient Oct 4, 2019
@nicolas-grekas nicolas-grekas changed the title [HttpClient] Fixed #33832 NO_PROXY option ignored in NativeHttpClient [HttpClient] fix "no_proxy" option ignored in NativeHttpClient Oct 4, 2019
@derrabus

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Should we cover this issue with a test?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Thank you @Harry-Dunne.

nicolas-grekas added a commit that referenced this pull request Oct 4, 2019
…ient (Harry-Dunne)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix "no_proxy" option ignored in NativeHttpClient

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33832
| License       | MIT
| Doc PR        |

Allow overriding of no_proxy environment variable by passing no_proxy option in NativeHttpClient::request() method.

Commits
-------

e4fb58d [HttpClient] Fixed #33832 NO_PROXY option ignored in NativeHttpClient::request() method
@nicolas-grekas nicolas-grekas merged commit e4fb58d into symfony:4.3 Oct 4, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@fabpot fabpot referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.