Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] gracefully handle docref_root ini setting #33863

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Oct 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33833
License MIT
Doc PR -
@Tobion
Tobion approved these changes Oct 4, 2019
nicolas-grekas added a commit that referenced this pull request Oct 5, 2019
…as-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[Routing] gracefully handle docref_root ini setting

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33833
| License       | MIT
| Doc PR        | -

Commits
-------

4d5530f [Routing] gracefully handle docref_root ini setting
@nicolas-grekas nicolas-grekas merged commit 4d5530f into symfony:4.3 Oct 5, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details
@stof

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

should we add a test running with docref_root configured to prevent regressions ?

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:route-errdoc branch Oct 7, 2019
@fabpot fabpot referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.