Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the intl notice if run with phpunit #33868

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@jakzal
Copy link
Member

commented Oct 5, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Re #33825
License MIT
Doc PR -
@jakzal

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

@jakzal

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

Build's green now :)

@yceruto
yceruto approved these changes Oct 6, 2019
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Oct 7, 2019
@nicolas-grekas nicolas-grekas force-pushed the jakzal:build-fix branch from e922fa1 to 25461b3 Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thank you @jakzal.

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #33868).

Discussion
----------

Skip the intl notice if run with phpunit

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Re #33825
| License       | MIT
| Doc PR        | -

Commits
-------

25461b3 Skip the intl notice if run with phpunit
@nicolas-grekas nicolas-grekas merged commit 25461b3 into symfony:master Oct 7, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@jakzal jakzal deleted the jakzal:build-fix branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.