Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Replace posix_isatty with cross-platform, always available stream_isatty #33878

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@ostrolucky
Copy link
Contributor

commented Oct 6, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

stream_isatty is always available since PHP 7.2, which is the minimal version required for Symfony 5.0, so we can remove usages of old, not cross-platform compatible posix_isatty

DeprecationErrorHandler left out, since AFAIK it's still meant to be compatible with PHP 5.5

@ostrolucky ostrolucky force-pushed the ostrolucky:posix_isatty-remove branch 2 times, most recently from abfb9e7 to bf8fa8c Oct 6, 2019
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Oct 7, 2019
@ostrolucky ostrolucky force-pushed the ostrolucky:posix_isatty-remove branch from bf8fa8c to 36fce21 Oct 7, 2019
@nicolas-grekas nicolas-grekas changed the title Replace posix_isatty with cross-platform, always available stream_isatty [Console] Replace posix_isatty with cross-platform, always available stream_isatty Oct 7, 2019
@ostrolucky ostrolucky force-pushed the ostrolucky:posix_isatty-remove branch from 36fce21 to c9b8b04 Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thank you @ostrolucky.

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
…ys available stream_isatty (ostrolucky)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Console] Replace posix_isatty with cross-platform, always available stream_isatty

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

stream_isatty is always available since PHP 7.2, which is the minimal version required for Symfony 5.0, so we can remove usages of old, not cross-platform compatible `posix_isatty`

DeprecationErrorHandler left out, since AFAIK it's still meant to be compatible with PHP 5.5

Commits
-------

c9b8b04 Replace posix_isatty with cross-platform, always available stream_isatty
@nicolas-grekas nicolas-grekas merged commit c9b8b04 into symfony:master Oct 7, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.