Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] add notice in UPGRADE file for new Range constraint option #33880

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@dmaicher
Copy link
Contributor

commented Oct 7, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Closes #33700
License MIT
Doc PR -

There is a change in behavior as mentioned in #33700 that causes small issues on one of my apps. I only noticed it because of a test fail.

Instead of reverting this nice feature I propose to document it in the UPGRADE file so that people are aware of it.

@Lctrs
Lctrs approved these changes Oct 7, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thank you @dmaicher.

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
…straint option (dmaicher)

This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] add notice in UPGRADE file for new Range constraint option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33700
| License       | MIT
| Doc PR        | -

There is a change in behavior as mentioned in #33700 that causes small issues on one of my apps. I only noticed it because of a test fail.

Instead of reverting this nice feature I propose to document it in the UPGRADE file so that people are aware of it.

Commits
-------

d4ab35c [Validator] add notice in UPGRADE file for new Range constraint option
@nicolas-grekas nicolas-grekas merged commit d4ab35c into symfony:4.4 Oct 7, 2019
2 of 3 checks passed
2 of 3 checks passed
fabbot.io Doing some proofreading and checking your coding style.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmaicher dmaicher deleted the dmaicher:issue-33700 branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.