Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] Added a support for casting Ramsey/Uuid #33881

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@lyrixx
Copy link
Member

commented Oct 7, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

I worked on a project using ramsey/uuid and I noticed a dumped uuid does
not contain the uuid. So here we go :)

(Note: don't get me wrong, I still do not recommend this lib)


Before / After:
Before / After

@lyrixx lyrixx force-pushed the lyrixx:uuid-caster branch 2 times, most recently from 1be19de to 41a02e0 Oct 7, 2019
@lyrixx lyrixx changed the title [VarDumper] Added a support for casting RamseyUuid [VarDumper] Added a support for casting Ramsey/Uuid Oct 7, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Oct 7, 2019
@lyrixx lyrixx force-pushed the lyrixx:uuid-caster branch from 41a02e0 to 35fbbb9 Oct 7, 2019
@nicolas-grekas nicolas-grekas force-pushed the lyrixx:uuid-caster branch from aa7336d to 99247bb Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 99247bb into symfony:4.4 Oct 7, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@lyrixx lyrixx deleted the lyrixx:uuid-caster branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.