Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] Made all casters final #33882

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@lyrixx
Copy link
Member

commented Oct 7, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR
@lyrixx lyrixx force-pushed the lyrixx:caster-final branch from 72a544b to 3044a91 Oct 7, 2019
@stof
stof approved these changes Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] Made all casters final

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

3044a91 [VarDumper] Made all casters final
@nicolas-grekas nicolas-grekas merged commit 3044a91 into symfony:4.4 Oct 7, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@lyrixx lyrixx deleted the lyrixx:caster-final branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.