Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Fix to populate $dotenvVars in data collector when not using putenv() #33900

Merged

Conversation

@mynameisbogdan
Copy link
Contributor

commented Oct 8, 2019

Q A
Branch? 4.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT

Fix to populate $dotenvVars in data collector when not using putenv()

Before:
Screen Shot 2019-10-08 at 03 53 49
After:
Screen Shot 2019-10-08 at 03 55 43

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Thank you @mynameisbogdan.

nicolas-grekas added a commit that referenced this pull request Oct 8, 2019
… when not using putenv() (mynameisbogdan)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpKernel] Fix to populate $dotenvVars in data collector when not using putenv()

| Q             | A
| ------------- | ---
| Branch?       | 4.3 for bug fixes
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT

Fix to populate $dotenvVars in data collector when not using putenv()

Before:
<img width="618" alt="Screen Shot 2019-10-08 at 03 53 49" src="https://user-images.githubusercontent.com/707714/66360303-49397280-e983-11e9-98b9-5272b9762dda.png">
After:
<img width="614" alt="Screen Shot 2019-10-08 at 03 55 43" src="https://user-images.githubusercontent.com/707714/66360304-4b9bcc80-e983-11e9-82de-46d484daa585.png">

Commits
-------

ca3fb25 [HttpKernel] fix $dotenvVars in data collector
@nicolas-grekas nicolas-grekas merged commit ca3fb25 into symfony:4.3 Oct 8, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.