Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Renamed a method argument #33904

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@javiereguiluz
Copy link
Member

commented Oct 8, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

I know this is tiny ... but I think it's needed to avoid confusion. The argument must be a complete regexp, including all the needed escaping ... so it's not only a pattern.

@javiereguiluz javiereguiluz added the String label Oct 8, 2019
@javiereguiluz javiereguiluz added this to the 5.0 milestone Oct 8, 2019
@gharlan

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Then $fromPattern in replaceMatches should be changed, too.

@javiereguiluz

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

@gharlan you are right! Done. Thanks.

@nicolas-grekas nicolas-grekas force-pushed the javiereguiluz:rename_argument branch from 4bb0f69 to 1648c0e Oct 8, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Thank you @javiereguiluz.

nicolas-grekas added a commit that referenced this pull request Oct 8, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #33904).

Discussion
----------

[String] Renamed a method argument

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I know this is tiny ... but I think it's needed to avoid confusion. The argument must be a complete regexp, including all the needed escaping ... so it's not only a pattern.

Commits
-------

1648c0e [String] Renamed a method argument
@nicolas-grekas nicolas-grekas merged commit 1648c0e into symfony:master Oct 8, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.