Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] improve perf of pruning for fs-based adapters #33921

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Oct 9, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #32701
License MIT
Doc PR -

Thank you Blackfire.io

https://blackfire.io/profiles/compare/8044c3cf-1541-4a24-9804-5670c63fcb4c/graph

image

image

@nicolas-grekas nicolas-grekas added this to the next milestone Oct 9, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-prune-perf branch 2 times, most recently from 658fafb to c40342b Oct 9, 2019
@stof
stof approved these changes Oct 9, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-prune-perf branch 2 times, most recently from 98cc70c to 416ae6a Oct 9, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-prune-perf branch 5 times, most recently from da50115 to 2029726 Oct 9, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-prune-perf branch from 2029726 to 0302b1d Oct 9, 2019
nicolas-grekas added a commit that referenced this pull request Oct 9, 2019
…olas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] improve perf of pruning for fs-based adapters

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #32701
| License       | MIT
| Doc PR        | -

Thank you [Blackfire.io](https://blackfire.io)

https://blackfire.io/profiles/compare/8044c3cf-1541-4a24-9804-5670c63fcb4c/graph

![image](https://user-images.githubusercontent.com/243674/66465435-22f9fc80-ea81-11e9-83fc-2444434a33e6.png)

![image](https://user-images.githubusercontent.com/243674/66465462-2d1bfb00-ea81-11e9-827a-4c0502cb5f4a.png)

Commits
-------

0302b1d [Cache] improve perf of pruning for fs-based adapters
@nicolas-grekas nicolas-grekas merged commit 0302b1d into symfony:4.4 Oct 9, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cache-prune-perf branch Oct 9, 2019
@Toflar

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

Thank you @nicolas-grekas!! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.