Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCA: added missing break in a loop #33938

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@kalessil
Copy link
Contributor

commented Oct 9, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a
Copy link
Member

left a comment

(for 3.4)

@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 3.4 Oct 9, 2019
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 9, 2019
@fabpot
fabpot approved these changes Oct 10, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Good catch, thanks @kalessil.

fabpot added a commit that referenced this pull request Oct 10, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

SCA: added missing break in a loop

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

6af04bb SCA: added missing break in a loop
@fabpot fabpot merged commit 6af04bb into symfony:3.4 Oct 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.