Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] fix resetting the "bold" state in CliDumper #33943

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 10, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 10, 2019
@stof

This comment has been minimized.

Copy link
Member

stof commented Oct 10, 2019

do we need the same for other non-bold styles ?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Oct 10, 2019

@stof that's already what the remaining of the default style does to me. I didn't notice any other issues.

@stof

This comment has been minimized.

Copy link
Member

stof commented Oct 10, 2019

So, only default needs to reset bold state, not note or stuff like that ?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Oct 10, 2019

It looks like so: there is always a default-styled character between any other style (even just a space).
At least I didn't catch any visual glitch related to another missing state reset.

nicolas-grekas added a commit that referenced this pull request Oct 11, 2019
…icolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] fix resetting the "bold" state in CliDumper

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

21645a5 [VarDumper] fix resetting the "bold" state in CliDumper
@nicolas-grekas nicolas-grekas merged commit 21645a5 into symfony:3.4 Oct 11, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:vd-fix branch Oct 14, 2019
This was referenced Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.