Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Add plus character `+` to legal mime subtype #33965

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@ilzrv
Copy link
Contributor

ilzrv commented Oct 12, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

For example, the following mime type (used for epub) is not recognized given the current regexp: application/epub+zip; charset=binary

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 12, 2019
@nicolas-grekas nicolas-grekas modified the milestones: 4.3, 3.4 Oct 12, 2019
For example, the following mime type (used for epub) is not recognized given the current regexp: `application/epub+zip`
@nicolas-grekas nicolas-grekas changed the base branch from 4.3 to 3.4 Oct 12, 2019
@nicolas-grekas nicolas-grekas force-pushed the ilzrv:patch-2 branch from 5055cd0 to 56895f1 Oct 12, 2019
@nicolas-grekas nicolas-grekas changed the title Add plus character `+` to legal mime subtype [HttpFoundation] Add plus character `+` to legal mime subtype Oct 12, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Oct 12, 2019

Thank you @ilzrv.

@ilzrv

This comment has been minimized.

Copy link
Contributor Author

ilzrv commented Oct 12, 2019

@nicolas-grekas You're welcome.

nicolas-grekas added a commit that referenced this pull request Oct 12, 2019
…ype (ilzrv)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Add plus character `+` to legal mime subtype

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

For example, the following mime type (used for epub) is not recognized given the current regexp: `application/epub+zip; charset=binary`

Commits
-------

56895f1 Add plus character `+` to legal mime subtype
@nicolas-grekas nicolas-grekas merged commit 56895f1 into symfony:3.4 Oct 12, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
This was referenced Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.