Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[Config] Disable default alphabet sorting in glob function due of unstable sort #33998
Conversation
41c11aa
to
c5fbcc1
c5fbcc1
to
cf7c751
This comment has been minimized.
This comment has been minimized.
isn't disabled sorting even more likely to produce different orders ? |
cf7c751
to
7a2ed47
This comment has been minimized.
This comment has been minimized.
Not able to reproduce issues with disabled sort. |
This comment has been minimized.
This comment has been minimized.
Would you be able to debug two different lists when sorting is enabled? Maybe that will allow us to better understand what's going on. |
This comment has been minimized.
This comment has been minimized.
Well, what exactly do you need? May I miss some information to provide? |
This comment has been minimized.
This comment has been minimized.
Two differently ordered list of files while the same input is provided would be nice. |
This comment has been minimized.
This comment has been minimized.
Oh, sure, with the order I've got randomly 2 lists:
and
I guess that the problem is with an underscore in doctrine yamls. |
This comment has been minimized.
This comment has been minimized.
ok thanks |
This comment has been minimized.
This comment has been minimized.
Got |
This comment has been minimized.
This comment has been minimized.
Thanks, that's why. |
da40a9f
to
809e68e
809e68e
to
49d06a6
…table sort
b690db5
to
3bed024
This comment has been minimized.
This comment has been minimized.
Thank you @hurricane-voronin. |
… due of unstable sort (hurricane-voronin) This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [Config] Disable default alphabet sorting in glob function due of unstable sort …table sort | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33990 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | no <!-- required for new features --> `\Symfony\Component\Config\Resource\GlobResource::getIterator` loads files using `glob` not it the stable sorting, e.g several files: `doctrine.yml` and `doctrine_mongodb.yaml` in `config/packages` folder. On requests these files come(randomly) in a different order, which leads to reinitialization of symfony kernel in `dev` environment. It's a little bit annoying and takes a lot of time in a common :( <!-- Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 3bed024 [Config] Disable default alphabet sorting in glob function due of unstable sort
hurricane-voronin commentedOct 16, 2019
…table sort
\Symfony\Component\Config\Resource\GlobResource::getIterator
loads files usingglob
not it the stable sorting, e.g several files:doctrine.yml
anddoctrine_mongodb.yaml
inconfig/packages
folder.On requests these files come(randomly) in a different order, which leads to reinitialization of symfony kernel in
dev
environment. It's a little bit annoying and takes a lot of time in a common :(