Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] fix wrong removal of the just generated container dir #34041

Merged
merged 1 commit into from Oct 20, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 20, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The patch applies to 3.4 but the fix really affects to 4.4 with the introduction of the new .preload.php file.

/cc @fabpot since you encountered this error quite often recently during composer up/req :)

@fabpot
fabpot approved these changes Oct 20, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Oct 20, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Oct 20, 2019
…iner dir (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] fix wrong removal of the just generated container dir

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The patch applies to 3.4 but the fix really affects to 4.4 with the introduction of the new `.preload.php` file.

/cc @fabpot since you encountered this error quite often recently during `composer up/req` :)

Commits
-------

4ad09eb [HttpKernel] fix wrong removal of the just generated container dir
@fabpot fabpot merged commit 4ad09eb into symfony:3.4 Oct 20, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-dump-preload branch Oct 20, 2019
This was referenced Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.