Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Fix handling of empty_data's \Closure value in Date/Time form types #34123

Open
wants to merge 1 commit into
base: 3.4
from

Conversation

@yceruto
Copy link
Member

yceruto commented Oct 25, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33188
License MIT
Doc PR -

Basically this would solve the posibility to pass a \Closure to the empty_data option for Date/Time form types.

https://symfony.com/doc/current/reference/forms/types/form.html#empty-data
If a form is compound, you can set empty_data as an array, object or closure. See the How to Configure empty Data for a Form Class article for more details about these options.

Also related to #29182

@yceruto yceruto force-pushed the yceruto:lazy_empty_data branch from fa43849 to 8a5798a Oct 26, 2019
@yceruto yceruto requested a review from xabbuh Oct 26, 2019
@yceruto

This comment has been minimized.

Copy link
Member Author

yceruto commented Nov 3, 2019

@xabbuh done, thanks!

@yceruto yceruto force-pushed the yceruto:lazy_empty_data branch from 8a5798a to 4939f0e Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.