Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos #34135

Merged

Conversation

@Tamarpe
Copy link
Contributor

Tamarpe commented Oct 26, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #30166
License MIT

Ref #30166

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Oct 27, 2019

Thank you for your contribution. Can you also add the translations for ids between 79 and 94?

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 27, 2019
@nicolas-grekas nicolas-grekas changed the title [Validator] Add the missing translations for the Hebrew ("he") locale… [Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos Oct 27, 2019
@Tamarpe

This comment has been minimized.

Copy link
Contributor Author

Tamarpe commented Oct 27, 2019

Thank you for your contribution. Can you also add the translations for ids between 79 and 94?

Done! the pull request is updated.

@Tamarpe Tamarpe force-pushed the Tamarpe:add-missing-he-validator-translation-file branch from c633e54 to eb3507d Nov 5, 2019
@Tamarpe

This comment has been minimized.

Copy link
Contributor Author

Tamarpe commented Nov 5, 2019

Fixed- a104eab

@fabpot
fabpot approved these changes Nov 5, 2019
@fabpot fabpot force-pushed the Tamarpe:add-missing-he-validator-translation-file branch from a104eab to 022cf67 Nov 5, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Nov 5, 2019

Thank you @Tamarpe.

fabpot added a commit that referenced this pull request Nov 5, 2019
…("he") locale and fix 2 typos (Tamarpe)

This PR was squashed before being merged into the 3.4 branch (closes #34135).

Discussion
----------

[Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #30166
| License       | MIT

Ref #30166

Commits
-------

022cf67 [Validator] Add the missing translations for the Hebrew (\"he\") locale and fix 2 typos
@fabpot fabpot merged commit 022cf67 into symfony:3.4 Nov 5, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.