Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inflector] add support for 'species' #34244

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@jeffreymoelands
Copy link
Contributor

jeffreymoelands commented Nov 5, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This PR improves the inflection of the word 'species'

@fabpot
fabpot approved these changes Nov 5, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Nov 5, 2019

Can we target 3.4 instead?

@jeffreymoelands jeffreymoelands changed the base branch from 4.3 to 3.4 Nov 6, 2019
@jeffreymoelands jeffreymoelands changed the base branch from 3.4 to 4.3 Nov 6, 2019
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 6, 2019
Copy link
Member

nicolas-grekas left a comment

(for 4.3 - this doesn't apply to 3.4, I just had a look.)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 6, 2019

Thank you @jeffreymoelands.

nicolas-grekas added a commit that referenced this pull request Nov 6, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Inflector] add support for 'species'

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This PR improves the inflection of the word 'species'
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

cc87e40 add species to inflector and inflector tests
@nicolas-grekas nicolas-grekas merged commit cc87e40 into symfony:4.3 Nov 6, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@fabpot fabpot referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.