Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Use context to compute MetadataAwareNameConverter cache #34246

Conversation

@antograssiot
Copy link
Contributor

antograssiot commented Nov 6, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This is a follow up PR to #34035 to address @nicolas-grekas 's comment

The static cache has been re-introduced and the context is used to compute the cache key used for denormalization

@antograssiot antograssiot requested a review from dunglas as a code owner Nov 6, 2019
@antograssiot antograssiot force-pushed the antograssiot:serializer-metadata-aware-name-converter branch 2 times, most recently from 33a3953 to c8311ee Nov 6, 2019
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Nov 6, 2019
@antograssiot antograssiot force-pushed the antograssiot:serializer-metadata-aware-name-converter branch from c8311ee to 57eb533 Nov 6, 2019
@antograssiot

This comment has been minimized.

Copy link
Contributor Author

antograssiot commented Nov 6, 2019

Thanks for your review @nicolas-grekas , I've updated all points as requested and rebased

@antograssiot antograssiot force-pushed the antograssiot:serializer-metadata-aware-name-converter branch from 57eb533 to 0ac5346 Nov 6, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 6, 2019

Thank you @antograssiot.

nicolas-grekas added a commit that referenced this pull request Nov 6, 2019
…rter cache (antograssiot)

This PR was merged into the 4.3 branch.

Discussion
----------

[Serializer] Use context to compute MetadataAwareNameConverter cache

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This is a follow up PR to #34035 to address @nicolas-grekas 's [comment](#34035 (comment))

The static cache has been re-introduced and the context is used to compute the cache key used for denormalization

Commits
-------

0ac5346 [Serializer] Use context to compute MetadataAwareNameConverter cache
@nicolas-grekas nicolas-grekas merged commit 0ac5346 into symfony:4.3 Nov 6, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@antograssiot antograssiot deleted the antograssiot:serializer-metadata-aware-name-converter branch Nov 6, 2019
@fabpot fabpot referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.