Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] Reopen DoctrineDataCollector to extensibility #34257

Merged

Conversation

@fancyweb
Copy link
Contributor

fancyweb commented Nov 6, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

DoctrineBundle is using it (https://github.com/doctrine/DoctrineBundle/blob/0d20a98fb80807e020e9371625dba4e81dad157a/DataCollector/DoctrineDataCollector.php#L41) and we don't want to prevent them from doing it.

@fancyweb fancyweb force-pushed the fancyweb:doctrine-bridge-reopen-data-collector branch from 4a8c8a3 to af02124 Nov 6, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 6, 2019

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Nov 6, 2019
…bility (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] Reopen DoctrineDataCollector to extensibility

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | -

DoctrineBundle is using it (https://github.com/doctrine/DoctrineBundle/blob/0d20a98fb80807e020e9371625dba4e81dad157a/DataCollector/DoctrineDataCollector.php#L41) and we don't want to prevent them from doing it.

Commits
-------

af02124 [DoctrineBridge] Reopen DoctrineDataCollector to extensibility
@nicolas-grekas nicolas-grekas merged commit af02124 into symfony:4.4 Nov 6, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Nov 6, 2019
…-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] fix min version of http-kernel

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Required after #34257 and #34230

Commits
-------

69ba86b [DoctrineBridge] fix min version of http-kernel
@fancyweb fancyweb deleted the fancyweb:doctrine-bridge-reopen-data-collector branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.