Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove \Throwable bubbling down support deprecation layer #34265

Merged

Conversation

@fancyweb
Copy link
Contributor

fancyweb commented Nov 6, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Remove deprecation layer of #33065

@fancyweb fancyweb requested review from sroze and xabbuh as code owners Nov 6, 2019
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Nov 6, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 6, 2019

Can you please rebase to trigger the CI again?

@fancyweb fancyweb force-pushed the fancyweb:remove-allow-throwables-deprecations branch 2 times, most recently from db14f3a to 1b402f1 Nov 6, 2019
@fancyweb fancyweb force-pushed the fancyweb:remove-allow-throwables-deprecations branch 3 times, most recently from 1808c0a to 8eae4cd Nov 7, 2019
Copy link
Member

nicolas-grekas left a comment

(once comments are addressed)

src/Symfony/Component/HttpKernel/composer.json Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@fancyweb fancyweb force-pushed the fancyweb:remove-allow-throwables-deprecations branch from 8eae4cd to b0ac75e Nov 7, 2019
nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

Unallow symfony/http-kernel ^5.0

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #34265 (comment)
| License       | MIT
| Doc PR        | -

The components that have a data collector cannot be compatible with HttpKernel `DataCollectorInterface` 5.0.

Commits
-------

da454db Unallow symfony/http-kernel ^5.0
@fancyweb fancyweb force-pushed the fancyweb:remove-allow-throwables-deprecations branch from b0ac75e to 41d6706 Nov 8, 2019
@nicolas-grekas nicolas-grekas force-pushed the fancyweb:remove-allow-throwables-deprecations branch from 41d6706 to ffcfdb4 Nov 8, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 8, 2019

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
…r (fancyweb)

This PR was merged into the 5.0-dev branch.

Discussion
----------

Remove \Throwable bubbling down support deprecation layer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Remove deprecation layer of #33065

Commits
-------

ffcfdb4 Remove \Throwable support deprecation layer
@nicolas-grekas nicolas-grekas merged commit ffcfdb4 into symfony:master Nov 8, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@fancyweb fancyweb deleted the fancyweb:remove-allow-throwables-deprecations branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.