Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap_4_layout.html.twig #34278

Open
wants to merge 2 commits into
base: 4.4
from

Conversation

@CoalaJoe
Copy link
Contributor

CoalaJoe commented Nov 7, 2019

Add lang attribute to enable translating the "Browse" after text using SCSS variables.
Example:

$custom-file-text: (
        en: "Browse",
        de: "Auswählen"
);

https://github.com/twbs/bootstrap/blob/v4.3.1/scss/_variables.scss#L640

Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #
License MIT
Doc PR symfony/symfony-docs#...
Add lang attribute to enable translating the "Browse" after text using SCSS variables.
Example:
```
$custom-file-text: (
        en: "Browse",
        de: "Auswählen"
);
```

https://github.com/twbs/bootstrap/blob/v4.3.1/scss/_variables.scss#L640
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 7, 2019

Can you please have a look at failing tests?
Please also update the table in the description of your PR, we need them to be filled in to triage things.
Thanks.

@ogizanagi ogizanagi added TwigBridge and removed Bug Deprecation labels Nov 8, 2019
@fabpot fabpot modified the milestones: 4.4, next Nov 9, 2019
@CoalaJoe

This comment has been minimized.

Copy link
Contributor Author

CoalaJoe commented Nov 11, 2019

@nicolas-grekas Do you have an idea why the one travis pipline failes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.