Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ErrorHandler] Remove Symfony ClassLoader support in an error enhancer #34284

Merged

Conversation

@fancyweb
Copy link
Contributor

fancyweb commented Nov 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets #33053 (comment)
License MIT
Doc PR -

Throwing a deprecation for this on 4.4 looks useless to me as the component was deprecated 2 years ago and stopping its support will not break anything.

@stof
stof approved these changes Nov 7, 2019
@yceruto
yceruto approved these changes Nov 7, 2019
@Tobion
Tobion approved these changes Nov 7, 2019
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Nov 8, 2019
@fancyweb fancyweb force-pushed the fancyweb:error-handler-remove-sf-class-loader branch from dfc5cbb to e745654 Nov 8, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Nov 8, 2019

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
…error enhancer (fancyweb)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[ErrorHandler] Remove Symfony ClassLoader support in an error enhancer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #33053 (comment)
| License       | MIT
| Doc PR        | -

Throwing a deprecation for this on 4.4 looks useless to me as the component was deprecated 2 years ago and stopping its support will not break anything.

Commits
-------

e745654 [ErrorHandler] Remove Symfony ClassLoader support in an error enhancer
@nicolas-grekas nicolas-grekas merged commit e745654 into symfony:master Nov 8, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@fancyweb fancyweb deleted the fancyweb:error-handler-remove-sf-class-loader branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.