Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] fix SodiumVault after stof review #34285

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 7, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

As spotted by @stof in #34275 (review)

@stof
stof approved these changes Nov 7, 2019
@nicolas-grekas nicolas-grekas merged commit a594599 into symfony:4.4 Nov 8, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
…as-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix SodiumVault after stof review

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As spotted by @stof in #34275 (review)

Commits
-------

a594599 [FrameworkBundle] fix SodiumVault after stof review
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:secret-fi branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.